475197 - -moz-box-shadow does not work on <button> and some <input> types

Status: VERIFIED FIXED

(Core :: Layout: Form Controls, defect, P3)

Description

[eisa01]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.2a1pre) Gecko/20090124 Minefield/3.2a1pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.2a1pre) Gecko/20090124 Minefield/3.2a1pre

The -moz-box-shadow property does not work on input elements. It does work in Safari 3.2.1

Reproducible: Always




See attached file. I have made the button using a div so you can see how it should look. Also included the -webkit-box-shadow property, so you can see it render in webkit.

Comment 1

[eisa01]

Attachment: test case

Comment 2

[j.j.]

Attachment: testcase 2

Same problem with <button>

Comment 3

[Boris Zbarsky [:bzbarsky]]

Yep.  Buttons don't call nsFrame::DisplayBorderBackgroundOutline; they do special border/background/outline painting.  See nsHTMLButtonControlFrame::BuildDisplayList.

Michael, want to fix this?

Comment 4

[j.j.]

Attachment: testcase 3 (styled buttons; IE-compatible)

Comment 5

[Michael Ventnor]

Attachment: [checked-in] Patch

I also fixed things for fieldset considering it uses its own callers as well.

Comment 6

[Boris Zbarsky [:bzbarsky]]

Is there a way to reftest this?  At least a != test with the same but without text/shadow... With buttons you might be able to use divs as the reference.

Comment 7

[Michael Ventnor]

Attachment: [checked-in] Reftest

Comment 8

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Pushed http://hg.mozilla.org/mozilla-central/rev/777f55d55ccc and http://hg.mozilla.org/mozilla-central/rev/daca86bf5d85.

Comment 9

[philippe (part-time)]

Should the box-shadow apply when the form-control is otherwise unstyled (aka native) ? The native widgets in attachment (id=358660) look pretty ugly on OS X.
WebKit/Safari (on OS X 10.5.6 at least) drops the box-shadow unless the author has styled the widget (border, background etc).

Comment 10

[philippe (part-time)]

Attachment: screenshot testcase 3

attachment (id=358660) in WebKit (left) and Minefield (20090128 build).

Comment 11

[Boris Zbarsky [:bzbarsky]]

> WebKit/Safari (on OS X 10.5.6 at least) drops the box-shadow

I suspect that's an artifact of their rendering codepaths, just like this bug was an artifact of ours.  Per current spec, there should certainly be a box-shadow there...

Comment 12

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Yeah, that's just a Webkit bug.

If we wanted to do something here, we would treat box-shadow as author style and drop the native look for widgets with shadows.

Comment 13

[j.j.]

(In reply to comment #9)
> WebKit/Safari (on OS X 10.5.6 at least) drops the box-shadow

Safari and Chrome draw the shadow on Win XP, except for "radio" and "checkbox".

Comment 14

[philippe (part-time)]

(In reply to comment #13)
> (In reply to comment #9)
> > WebKit/Safari (on OS X 10.5.6 at least) drops the box-shadow
> 
> Safari and Chrome draw the shadow on Win XP, except for "radio" and "checkbox".
Ah, thanks, I hadn't tested on Windows.

(In reply to comment #12)
 
> If we wanted to do something here, we would treat box-shadow as author style
> and drop the native look for widgets with shadows.

That is what I actually would have expected.
And it is what I suspect WebKit Mac actually does, and I didn't find any bug in their database unless it is in rdar.
Note, I doubt authors would actually use box-shadow without any other styling on form controls.

Comment 15

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Alright, please file a followup bug for that. You can assign it to Michael.

Comment 16

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Sorry but the shadows for buttons aren't entirely there. I still miss the shadow for the browse button of the <input type=file> elements. There is no shadow drawn.

Tested with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090129 Minefield/3.2a1pre ID:20090129020336

Comment 17

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Can you file a new bug for that?

We probably need -moz-box-shadow:inherit on the anonymous button and textbox for file inputs.

Comment 18

[Michael Ventnor]

Attachment: Also fix file uploaders

This is all we really can do considering we do some kind fo clipping on the file control frame...

Comment 19

[Michael Ventnor]

Attachment: Reftest for file upload control

Reftests: roc loves them, I have to make them :/

Comment 20

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Pushed file upload control patch to trunk: http://hg.mozilla.org/mozilla-central/rev/00f74e51fe52

Comment 21

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 359624 [details] [diff] [review]
Also fix file uploaders

Simple fix for a bug in a new feature

Comment 22

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 358976 [details] [diff] [review]
[checked-in] Patch

Simple fix for a bug in a new feature

Comment 23

[Boris Zbarsky [:bzbarsky]]

This caused bug 476308.  Please don't land on 1.9.1 until that's resolved?

Comment 24

[Robert O'Callahan (:roc) (email my personal email if necessary)]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/8be6f1f1bb3c
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/80a57a22c967
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/23adc0bc597d

I forgot to land 476308 at the same time, but that fix is ready to land and should be pushed to 1.9.1 ASAP.

Comment 25

[Henrik Skupin [:whimboo][⌚️UTC+2]]

(In reply to comment #10)
> Created an attachment (id=359253) [details]
> screenshot testcase 3

Roc, why we still have this ugly white backgrounds for buttons which can also be seen in this screenshot? Shouldn't this be fixed too?

Comment 26

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Yes, can you please file a new bug for comment #12?

Comment 27

[philippe (part-time)]

(In reply to comment #26)
> Yes, can you please file a new bug for comment #12?
that is bug 476062, right ?

Comment 28

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Yes thanks!

Comment 29

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Ah, missed that bug. Sorry.

Ok, otherwise that looks good. Verified fixed with builds on OS X and Windows:

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090227 Minefield/3.2a1pre

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b3pre) Gecko/20090227 Shiretoko/3.1b3pre ID:20090227020413